Repository navigation
Drop the trapped margin above the dots on two Hawaii pages - #66
Merged
Merged
Conversation
The centered block above the first dots divider on Obama's Neighborhood and Hike To Diamond Head Lighthouse is a flex column, and flex containers never collapse their items' margins. The block's trailing paragraph kept its 20px margin-bottom inside the container's border box, where it could not collapse with the divider's own margin-block and instead stacked on top of it: 52px above the dots against 34px below, so the dots sat low rather than centred in the break. Zero that last item's bottom margin on both pages and the divider owns the whole gap again, matching the 34px every other divider on the site already has on both sides. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XB5gBAQPTA7hFETKF4EANj
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Visual regression:
|
| Page | Status | Pixels changed | Notes |
|---|---|---|---|
/contents/hawaii/hike-to-diamond-head-lighthouse/ |
🔴 changed | 340,081 (6.21%) | page size 1280x4277 -> 1280x4257; diff: diffs/contents_hawaii_hike-to-diamond-head-lighthouse.png |
/contents/hawaii/obama-s-neighborhood/ |
🔴 changed | 145,751 (6.81%) | page size 1280x1673 -> 1280x1653; diff: diffs/contents_hawaii_obama-s-neighborhood.png |
Diff images are in the visual-regression-report artifact on this run.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The centered block above the first dots divider on Obama's Neighborhood
and Hike To Diamond Head Lighthouse is a flex column, and flex containers
never collapse their items' margins. The block's trailing paragraph kept
its 20px margin-bottom inside the container's border box, where it could
not collapse with the divider's own margin-block and instead stacked on
top of it: 52px above the dots against 34px below, so the dots sat low
rather than centred in the break.
Zero that last item's bottom margin on both pages and the divider owns
the whole gap again, matching the 34px every other divider on the site
already has on both sides.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01XB5gBAQPTA7hFETKF4EANj